Skip to content

chore: run pre-commit on all files #10119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aaron-ang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: run pre-commit on all files #10119

aaron-ang wants to merge 1 commit into from

Conversation

@aaron-ang
Copy link
Contributor

@aaron-ang aaron-ang commented Jan 8, 2026 •
edited
Loading

Excluded test fixtures.

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@ChrisDryden
Copy link
Collaborator

ChrisDryden commented Jan 8, 2026

Most of the examples in the PR are there on purpose such as the whitespace files for integration tests

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@ChrisDryden
Copy link
Collaborator

ChrisDryden commented Jan 8, 2026

How does it work with the patches files, since they have to match what existed before don't they have to keep all formatting issues? Might be a good idea to exclude all of those ones too

@aaron-ang
Copy link
Contributor Author

aaron-ang commented Jan 8, 2026 •
edited
Loading

How does it work with the patches files, since they have to match what existed before don't they have to keep all formatting issues? Might be a good idea to exclude all of those ones too

The formatting removed trailing whitespace in existing blank lines in patch files, so it shouldn't affect testing (CI also passes).

The localization CI error seems unrelated.

@aaron-ang
Copy link
Contributor Author

aaron-ang commented Jan 13, 2026 •
edited
Loading

@ChrisDryden, could you PTAL again? Only whitespace is changed in the patch files. The + and - prefixes are mistakenly identified as diffs by GitHub.

@github-actions
Copy link

github-actions bot commented Jan 21, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/env/env-signal-handler is now passing!

@github-actions
Copy link

github-actions bot commented Jan 21, 2026

GNU testsuite comparison:

GNU test failed: tests/sort/sort-debug-keys. tests/sort/sort-debug-keys is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/env/env-signal-handler is now passing!

@github-actions
Copy link

github-actions bot commented Jan 21, 2026

GNU testsuite comparison:

GNU test failed: tests/sort/sort-debug-keys. tests/sort/sort-debug-keys is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/env/env-signal-handler is now passing!

@github-actions
Copy link

github-actions bot commented Jan 22, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@aaron-ang
Copy link
Contributor Author

aaron-ang commented Jan 23, 2026 •
edited
Loading

hi @sylvestre is this good to merge? CI error seems unrelated..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aaron-ang @ChrisDryden